some docs + clippy fixes

This commit is contained in:
AF 2023-03-12 20:04:41 +00:00
parent 28f53fb698
commit b264389cbf
4 changed files with 43 additions and 10 deletions

View File

@ -10,6 +10,46 @@ pub trait WeakFunctor {
type F<'a, A>; type F<'a, A>;
} }
/// Rust-specific implementation of [Functor], respecting `move` semantics.
///
/// Cannot insantiate for e.g. multi-element collections:
/// ```compile_fail
/// use radn_rs::func::*;
///
/// struct VecClass;
///
/// impl WeakFunctor for VecClass {
/// type F<'a, A> = Vec<A>;
/// }
///
/// impl Functor for VecClass {
/// fn fmap<'a, A: 'a, B: 'a, F: 'a + FnOnce(A) -> B>(f: F, fa: Self::F<'a, A>) -> Self::F<'a, B> {
/// fa.into_iter().map(f).collect()
/// }
/// }
/// ```
/// Why does it fail to compile? `.map` expects `FnMut` (or we can think of it being `Fn`, doesn't matter here). But what we provide it (`f`) is
///
/// For Haskell-style Functors, use [clone_func::CloneFunctor] instead.
/// ```
/// use radn_rs::func::clone_func::*;
///
/// struct VecClass;
///
/// impl CloneWeakFunctor for VecClass {
/// type ClF<'a, A: Clone> = Vec<A>;
/// }
///
/// impl CloneFunctor for VecClass {
/// fn clone_fmap<'a, A: 'a + Clone, B: 'a + Clone, F: 'a + Fn(A) -> B>(
/// f: F,
/// fa: Self::ClF<'a, A>,
/// ) -> Self::ClF<'a, B> {
/// fa.into_iter().map(f).collect()
/// }
/// }
/// ```
pub trait Functor: WeakFunctor { pub trait Functor: WeakFunctor {
fn fmap<'a, A: 'a, B: 'a, F: 'a + FnOnce(A) -> B>(f: F, fa: Self::F<'a, A>) -> Self::F<'a, B>; fn fmap<'a, A: 'a, B: 'a, F: 'a + FnOnce(A) -> B>(f: F, fa: Self::F<'a, A>) -> Self::F<'a, B>;

View File

@ -8,17 +8,11 @@ impl WeakFunctor for OptionClass {
impl Functor for OptionClass { impl Functor for OptionClass {
fn fmap<'a, A: 'a, B: 'a, F: 'a + FnOnce(A) -> B>(f: F, fa: Self::F<'a, A>) -> Self::F<'a, B> { fn fmap<'a, A: 'a, B: 'a, F: 'a + FnOnce(A) -> B>(f: F, fa: Self::F<'a, A>) -> Self::F<'a, B> {
match fa { fa.map(f)
Some(a) => Some(f(a)),
None => None,
}
} }
fn replace<'a, A: 'a, B: 'a>(fa: Self::F<'a, A>, b: B) -> Self::F<'a, B> { fn replace<'a, A: 'a, B: 'a>(fa: Self::F<'a, A>, b: B) -> Self::F<'a, B> {
match fa { fa.map(|_| b)
Some(_) => Some(b),
None => None,
}
} }
} }

View File

@ -18,7 +18,6 @@ impl Functor for SoloClass {
fn void<'a, A: 'a>(fa: Self::F<'a, A>) -> Self::F<'a, ()> { fn void<'a, A: 'a>(fa: Self::F<'a, A>) -> Self::F<'a, ()> {
drop(fa); drop(fa);
()
} }
} }

View File

@ -67,7 +67,7 @@ pub trait CloneApplicativeSeq: CloneFunctor {
Self::clone_fmap( Self::clone_fmap(
move |a| { move |a| {
let cf = f.clone(); let cf = f.clone();
move |b: B| cf(a.clone(), b.clone()) move |b: B| cf(a.clone(), b)
}, },
fa, fa,
), ),